Re: [PATCH] Remove useless USE_PGXS support in contrib

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: amul sul <sul_amul(at)yahoo(dot)co(dot)in>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Remove useless USE_PGXS support in contrib
Date: 2013-06-19 02:51:27
Message-ID: 1371610287.13762.22.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 2013-06-14 at 09:32 -0400, Andrew Dunstan wrote:
> I do think we need to make sure that we have at least buildfarm
> coverage of pgxs module building and testing. I have some coverage of
> a few extensions I have written, which exercise that, so maybe that
> will suffice. If not, maybe we need to have one module that only
> builds via pgxs and is build after an install (i.e. not via the
> standard contrib build).

The way to test pgxs is to build actual pgxs modules, and possibly some
unit tests made for the purpose. Testing with fake hybrid modules that
will never actually appear that way in practice isn't going to satisfy
anyone.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2013-06-19 02:56:16 Re: [PATCH] Remove useless USE_PGXS support in contrib
Previous Message Peter Eisentraut 2013-06-19 02:48:11 Re: Bugfix and new feature for PGXS