Re: Materialized View patch broke pg_dump

From: Kevin Grittner <kgrittn(at)ymail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Bernd Helmle <mailings(at)oopsware(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Materialized View patch broke pg_dump
Date: 2013-03-13 19:24:49
Message-ID: 1363202689.91937.YahooMailNeo@web162906.mail.bf1.yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> On 03/11/2013 12:30 PM, Fujii Masao wrote:
>> Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>> On 03/11/2013 10:43 AM, Andrew Dunstan wrote:

>>>> I noticed this morning that I am still getting failures on
>>>> 9.0, 9.1 and 9.2 which cause my cross-version upgrade testing
>>>> to fail for git tip. For
>>>> all I know this might apply to all back branches, but these
>>>> are the only ones tested for upgrade, so that's all I can
>>>> report on reliably.
>>>>
>>>> I'm chasing it up to find out exactly what's going on, but
>>>> figured some extra eyeballs would help.
>>>>
>>>>
>>> The problem is that pg_dump is sending an empty query in
>>> versions less than 9.3, and choking on that. Suggested fix
>>> attached - there's really no reason to be doing anything re mat
>>> views in versions < 9.3. This is the same problem that I
>>> reported in another thread.
>>
>
>
http://www.postgresql.org/message-id/CAHGQGwH+4vtyq==
L6HRuPxTggfqrnLf0mWj75BfisOske28gMA(at)mail(dot)gmail(dot)com
>>
>>
>
> Oh, I missed that. Yes, either of these would work.

I've been out of town and not able to keep up here for a few days.
Will push a fix today unless I find that someone has beaten me to
it as I work through the rest of the messages.

--
Kevin Grittner
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2013-03-13 20:07:21 Re: pg_dump selectively ignores extension configuration tables
Previous Message Kevin Grittner 2013-03-13 19:18:38 Re: matview join view error