Re: Working toward a JTA 1.0.1 Compliant XADataSource

Dave Cramer <pg(at)fastcrypt(dot)com> wrote:
> Hannu Krosing <hannu(at)2ndquadrant(dot)com> wrote:
>> Dave Cramer wrote:
>>> Bryan Varner <bvarner(at)polarislabs(dot)com> wrote:

>>>> If the src directory and build changes are going to be an
>>>> obstacle to getting this work accepted upstream, now would be
>>>> a good time to tell me.

>>> Yes, moving everything to src will not work for the project.

>> Could you also tell _why_ it would not work ?

> There's no technical reason as to why it would not work.
>
> The project has used this layout for as long as I can remember.
> If we were to change it for this patch why not change it for
> every patch ?

My opinions, FWIW:

(1)  A change like this should be done as a separate patch, so that
it doesn't make it harder to find substantive logical changes to
the code.  I recommend that you offer the improvements to
XADataSource without the source file relocation, and if you want to
convince people to reorganize the directory structure work on that
at a different time on a new thread.

(2)  I strongly prefer having a src directory below the top level.

(3)  I don't think anyone is advocating that each patch be allowed
to reorganize the directory structure; it's a question of which is
the best way to organize it long-term.

--
Kevin Grittner
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company