From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Israel Barth Rubio <barthisrael(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Apparent bug in WAL summarizer process (hung state) |
Date: | 2024-06-25 19:51:24 |
Message-ID: | 1354610.1719345084@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> Yeah, this is a bug. It seems that the WAL summarizer process, when
> restarted, wants to restart from wherever it was previously
> summarizing WAL, which is correct if that WAL is still around, but if
> summarize_wal has been turned off in the meanwhile, it might not be
> correct. Here's a patch to fix that.
This comment seems to be truncated:
+ /*
+ * If we're the WAL summarizer, we always want to store the values we
+ * just computed into shared memory, because those are the values we're
+ * going to use to drive our operation, and so they are the authoritative
+ * values. Otherwise, we only store values into shared memory if they are
+ */
+ LWLockAcquire(WALSummarizerLock, LW_EXCLUSIVE);
+ if (am_wal_summarizer|| !WalSummarizerCtl->initialized)
+ {
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2024-06-25 20:04:03 | Re: improve predefined roles documentation |
Previous Message | Robert Haas | 2024-06-25 19:48:07 | Re: Apparent bug in WAL summarizer process (hung state) |