From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Greg Stark <stark(at)mit(dot)edu>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: WIP patch for avoiding duplicate initdb runs during "make check" |
Date: | 2017-07-03 14:00:53 |
Message-ID: | 13530.1499090453@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Mon, Jul 3, 2017 at 9:25 PM, Greg Stark <stark(at)mit(dot)edu> wrote:
>> On 2 July 2017 at 18:33, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> system("cp -a ...") call in favor of something more portable.
>> If we're ok with using Perl there's File::Copy::Recursive::dircopy()
>> which does exactly that.
> This stuff needs to support perl down to 5.8.0, and that's a reason
> behind having src/test/perl/RecursiveCopy.pm. So I would suggest just
> to use that. cp is not portable on Windows as well, that's a recipe
> for non-portable code there.
I can't see going this path in pg_regress, because then you would have
exactly zero test functionality in a non-Perl build. What I had in
mind was a frontend-friendly version of backend/storage/file/copydir.c,
either just dropped into pg_regress.c or put in src/common/.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Chapman Flack | 2017-07-03 14:13:03 | Re: AdvanceXLInsertBuffer vs. WAL segment compressibility |
Previous Message | Tom Lane | 2017-07-03 13:53:35 | Re: Error while copying a large file in pg_rewind |