| From: | Chapman Flack <chap(at)anastigmatix(dot)net> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Robert Haas <robertmhaas(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: AdvanceXLInsertBuffer vs. WAL segment compressibility |
| Date: | 2017-07-03 14:13:03 |
| Message-ID: | 0381c524-6e62-d6ad-200e-f0522141e1c6@anastigmatix.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07/03/2017 09:39 AM, Heikki Linnakangas wrote:
> The most straightforward solution would be to just clear each page with
> memset() in the loop. It's a bit wasteful to clear the page again, just
> after AdvanceXLInsertBuffer() has initialized it, but this isn't
> performance-critical.
An in that straightforward approach, I imagine it would suffice to
memset just the length of a (short) page header; the page content
is already zeroed, and there isn't going to be a switch at the very
start of a segment, so a long header won't be encountered ... will it?
-Chap
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2017-07-03 14:30:21 | Re: Default Partition for Range |
| Previous Message | Tom Lane | 2017-07-03 14:00:53 | Re: WIP patch for avoiding duplicate initdb runs during "make check" |