Re: pgsql: Fix misbehavior of DROP OWNED BY with duplicate polroles entries

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix misbehavior of DROP OWNED BY with duplicate polroles entries
Date: 2021-06-19 02:42:41
Message-ID: 1348803.1624070561@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> This indentation is incorrect.

Yeah, I intentionally didn't reindent the code that's now inside
the inner if-block. It would have made back-patching more painful
(because that chunk isn't identical across branches). And I think
we're going to be rewriting that whole function in a little bit,
so I see no need to be very fussy about how pretty the intermediate
state is. I just pushed that because I didn't want to ship beta2
with a known crasher bug.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2021-06-19 03:04:25 pgsql: Support disabling index bypassing by VACUUM.
Previous Message Michael Paquier 2021-06-18 23:18:18 Re: pgsql: Fix misbehavior of DROP OWNED BY with duplicate polroles entries