| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Tomas Vondra <tomas(at)vondra(dot)me>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Japin Li <japinli(at)hotmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Cannot find a working 64-bit integer type on Illumos |
| Date: | 2025-03-25 23:36:34 |
| Message-ID: | 1338393.1742945794@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> On 26 Mar 2025, at 00:01, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> How did that work before? Perhaps somebody just now added a libpq
>> dependency to pg_regress.c?
> I believe the libpq dependency came in 66d6086cbcbfc8 which wasn't all that
> recent.
It looks like this has been broken for a very long time, but it must
never have mattered before because libpq-fe.h is so stable, and
pg_regress doesn't use any new-ish APIs from it. So pulling in
whatever version the platform had still worked.
I think this should work to fix it:
-pg_regress.o: override CPPFLAGS += -I$(top_builddir)/src/port -I$(libpq_srcdir) $(EXTRADEFS)
+pg_regress.o: override CPPFLAGS := -I$(top_builddir)/src/port -I$(libpq_srcdir) $(EXTRADEFS) $(CPPFLAGS)
but I haven't tested yet.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2025-03-25 23:45:16 | Re: Adding skip scan (including MDAM style range skip scan) to nbtree |
| Previous Message | Tom Lane | 2025-03-25 23:24:20 | Re: query_id: jumble names of temp tables for better pg_stat_statement UX |