| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Greg Smith <greg(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us> |
| Subject: | Re: Command Triggers |
| Date: | 2012-02-16 21:19:57 |
| Message-ID: | 1329426351-sup-5633@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Excerpts from Dimitri Fontaine's message of jue feb 16 14:42:26 -0300 2012:
> Hi,
>
> Please find attached version 8 of the patch, which fixes most of your
> complaints.
Hi,
I didn't like the new cmdtrigger.h file. It's included by a lot of
other headers, and it's also itself including execnodes.h and
parsenodes.h which means practically the whole lot of the source tree
is included in turn. If you could split it, so that the struct
definition is in a different file that's only included by the few .c
files that actually use that struct, I'd be much happier.
... after looking at it more closely, I think only this line needs to be
in a separate file:
typedef struct CommandContextData *CommandContext;
and that file is included by other headers; they don't need the function
declarations or the struct definition.
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dimitri Fontaine | 2012-02-16 21:21:30 | Re: Command Triggers |
| Previous Message | Peter Geoghegan | 2012-02-16 21:11:56 | pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation) |