Re: pg_upgrade defaulting to port 25432

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Christopher Browne <cbbrowne(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_upgrade defaulting to port 25432
Date: 2011-06-24 23:19:39
Message-ID: 1308957579.9571.0.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On fre, 2011-06-24 at 16:34 -0400, Bruce Momjian wrote:
> > > It also creates two new environment variables,
> > > OLDPGPORT and NEWPGPORT, to control the port values because we
> don't
> > > want to default to PGPORT anymore.
> >
> > I would prefer that all PostgreSQL-related environment variables
> start
> > with "PG".
>
> OK, attached. I was also using environment variables for PGDATA and
> PGBIN do I renamed those too to begin with 'PG'.

I'm wondering why pg_upgrade needs environment variables at all. It's a
one-shot operation. Environment variables are typically used to shared
default settings across programs. I don't see how that applies here.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2011-06-24 23:27:55 Re: News on Clang
Previous Message David Christensen 2011-06-24 23:11:56 Re: Deriving release notes from git commit messages