From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Marko Kreen <markokr(at)gmail(dot)com> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Stark <gsstark(at)mit(dot)edu>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us> |
Subject: | Re: Please test peer (socket ident) auth on *BSD |
Date: | 2011-06-02 17:04:06 |
Message-ID: | 1307034204-sup-1498@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Excerpts from Marko Kreen's message of jue jun 02 12:45:04 -0400 2011:
> On Thu, Jun 2, 2011 at 7:31 PM, Alvaro Herrera
> <alvherre(at)commandprompt(dot)com> wrote:
> > Excerpts from Andrew Dunstan's message of jue jun 02 11:59:02 -0400 2011:
> >> On 06/02/2011 11:29 AM, Marko Kreen wrote:
> >> > As there was no going back now, I even touched msvc.pm.
> >>
> >> Why? Windows doesn't have Unix domain sockets at all.
> >
> > So much for being thorough :-P
>
> Well, there is 2 approaches to portable C code:
> 1) You #ifdef the main code portable
> 2) You #ifdef common platform in headers, then main code
> is written against common platform, without ifdefs.
>
> I'm from the camp #2.
I don't disagree, just saying that you seem to have gone out of your way
to produce something that doesn't seem to be necessary.
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-06-02 17:06:19 | Re: Please test peer (socket ident) auth on *BSD |
Previous Message | Robert Haas | 2011-06-02 16:54:59 | Re: Hacking gram.y Error syntax error at or near "MERGEJOIN" |