| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: windows consolidated cleanup |
| Date: | 2011-04-24 14:57:59 |
| Message-ID: | 1303657079.5006.2.camel@vanquo.pezone.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The hunk below looks a bit evil.
At least a comment would be good to explain why this is necessary.
On sön, 2011-04-24 at 01:29 -0400, Andrew Dunstan wrote:
> *** a/src/backend/port/win32/socket.c
> --- b/src/backend/port/win32/socket.c
> ***************
> *** 370,376 **** pgwin32_recv(SOCKET s, char *buf, int len, int f)
> }
>
> int
> ! pgwin32_send(SOCKET s, char *buf, int len, int flags)
> {
> WSABUF wbuf;
> int r;
> --- 370,376 ----
> }
>
> int
> ! pgwin32_send(SOCKET s, const char *buf, int len, int flags)
> {
> WSABUF wbuf;
> int r;
> ***************
> *** 380,386 **** pgwin32_send(SOCKET s, char *buf, int len, int flags)
> return -1;
>
> wbuf.len = len;
> ! wbuf.buf = buf;
>
> /*
> * Readiness of socket to send data to UDP socket may be not true: socket
> --- 380,386 ----
> return -1;
>
> wbuf.len = len;
> ! wbuf.buf = (char *) buf;
>
> /*
> * Readiness of socket to send data to UDP socket may be not true: socket
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2011-04-24 15:10:56 | Re: windows consolidated cleanup |
| Previous Message | Peter Eisentraut | 2011-04-24 14:53:34 | Re: windows consolidated cleanup |