Re: Restrict publishing of partitioned table with a foreign table as partition

29.01.2025 12:16, Shlok Kyal пишет:
> Hi,
>
> As part of a discussion in [1], I am starting this thread to address
> the issue reported for foreign tables.
>
> Logical replication of foreign tables is not supported, and we throw
> an error in this case. But when we create a publication on a
> partitioned table that has a foreign table as a partition, the initial
> sync of such a table is successful. We should also throw an error in
> such cases.
> With this patch, we will throw an error when we try to create a
> publication on (or add to an existing publication) a partitioned table
> with a foreign table as its partition or attach such a table to
> existing published tables.
>
> [1] : https://www.postgresql.org/message-id/CAA4eK1Lhh4SgiYQLNiWSNKGdVSzbd53%3Dsr2tQCKooEphDkUtgw%40mail.gmail.com
>
> Thanks and Regards,
> Shlok Kyal
Hi!

Thanks for patch.

I reviewed it and made some changes.

1. we should check foreign tables (not partitioned)
2. added checking for foreign table creation
3. some little corrections

See attach