| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: improved parallel make support |
| Date: | 2010-11-03 14:34:18 |
| Message-ID: | 1288794858.20884.6.camel@vanquo.pezone.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On tis, 2010-11-02 at 10:21 -0400, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > This patch requires GNU make 3.80, because of the above "|" feature and
> > the $(eval) function. Version 3.80 is dated October 2002, so it should
> > be no problem, but I do occasionally read of make 3.79 around here;
> > maybe it's time to get rid of that. I did put in a check that makes the
> > build fail right away if a wrong version of make is used.
>
> Do we have a handle on how many buildfarm members this will break?
I suppose we don't. One way to find out would be to commit just this
bit
+# We need the $(eval) function, which is available in GNU make 3.80.
+# That also happens to be the version where the .VARIABLES variable
+# was introduced, so this is a simple check.
+ifndef .VARIABLES
+$(error GNU make 3.80 or newer is required)
+endif
with a $(warning) instead, and let it run for a bit.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-11-03 14:42:12 | Re: improved parallel make support |
| Previous Message | Tom Lane | 2010-11-03 14:31:55 | Re: pgsql: Bootstrap WAL to begin at segment logid=0 logseg=1 (000000010000 |