Re: [PATCH] Cleanup: Compare pointers to NULL instead of 0

Excerpts from Marti Raudsepp's message of vie oct 29 13:25:03 -0300 2010:
> Coccinelle found a few places in the code where pointer expressions
> were compared to 0. I have changed them to NULL instead.
>
> There was one line that I didn't dare to touch, which looks like a
> false positive.
>
> src/backend/regex/regc_lex.c:849:
> if (v->now - save == 0 || ((int) c > 0 && (int) c <= v->nsubexp))
>
> I couldn't find the definition of v (struct vars) anywhere. Is it
> comparing two pointers here? Should it be "v->now == save" instead?

regcomp.c line 198. Yes, it's a pointer.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support