| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | Michael Fuhr <mike(at)fuhr(dot)org>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: port/snprintf.c (was Re: Numeric 508 datatype) |
| Date: | 2005-12-05 03:27:00 |
| Message-ID: | 12549.1133753220@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> The problems are sufficiently bad that it might be a good idea to
>> backport the fixes into 8.0 and before as well --- but I note that
>> the ABI is different (pg_snprintf vs snprintf, etc) so this requires
>> a bit of investigation rather than just committing the file as-is.
> Not as many 8.0.X platforms used *printf because we didn't test %$ for
> its use on that release, so my bet is that very few platforms would be
> using it.
Hm. One of the main problems I found was incorrect results for
LONGLONG_MIN (-2^63). I'm rather tempted to add a test case for
that to the int8 regression test and see if any platforms fail ;-)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jan Wieck | 2005-12-05 03:54:14 | Re: Selecting Large Object and TOAST |
| Previous Message | Bruce Momjian | 2005-12-05 03:18:10 | Re: port/snprintf.c (was Re: Numeric 508 datatype) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2005-12-05 04:16:25 | Re: port/snprintf.c (was Re: Numeric 508 datatype) |
| Previous Message | Bruce Momjian | 2005-12-05 03:18:10 | Re: port/snprintf.c (was Re: Numeric 508 datatype) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sergey E. Koposov | 2005-12-05 04:12:36 | Re: TODO item -- Improve psql's handling of multi-line |
| Previous Message | Bruce Momjian | 2005-12-05 03:22:08 | Re: TODO item -- Improve psql's handling of multi-line queries |