| From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Compiler warning cleanup - unitilized const variables, pointer type mismatch |
| Date: | 2009-05-29 12:36:41 |
| Message-ID: | 1243600601.1301.18.camel@localhost |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane píše v čt 28. 05. 2009 v 11:42 -0400:
> Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
> > I attached another cleanup patch which fixes following warnings reported
> > by Sun Studio:
>
> I'm not too impressed with any of these. The proposed added
> initializers just increase future maintenance effort without solving
> any real problem (since the variables are required by C standard to
> initialize to zero).
Agree.
> The proposed signature change on psql_completion
> is going to replace a warning on your system with outright failures on
> other people's.
I check readline and definition is still same at least from 5.0 version.
I'm not still understand why it should failure on other systems. I
looked on revision 1.30 of the file and there is only readline-4.2
support mentioned. Is readline 4.2 the problem?
Zdenek
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zdenek Kotala | 2009-05-29 12:44:12 | Re: Compiler warning cleanup - unitilized const variables, pointer type mismatch |
| Previous Message | Kevin Field | 2009-05-29 11:59:21 | Re: plperl error format vs plpgsql error format vs pgTAP |