Re: Compiler warning cleanup - unitilized const variables, pointer type mismatch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Compiler warning cleanup - unitilized const variables, pointer type mismatch
Date: 2009-05-28 15:42:03
Message-ID: 10558.1243525323@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
> I attached another cleanup patch which fixes following warnings reported
> by Sun Studio:

I'm not too impressed with any of these. The proposed added
initializers just increase future maintenance effort without solving
any real problem (since the variables are required by C standard to
initialize to zero). The proposed signature change on psql_completion
is going to replace a warning on your system with outright failures on
other people's.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2009-05-28 15:46:58 Re: PostgreSQL Developer meeting minutes up
Previous Message Robert Haas 2009-05-28 15:41:53 Re: User-facing aspects of serializable transactions