Re: patch for space around the FragmentDelimiter

From: Sushant Sinha <sushant354(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: patch for space around the FragmentDelimiter
Date: 2009-03-02 02:59:31
Message-ID: 1235962771.11108.1.camel@dragflick
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

yeah you are right. I did not know that you can pass space using double
quotes.

-Sushant.

On Sun, 2009-03-01 at 20:49 -0500, Tom Lane wrote:
> Sushant Sinha <sushant354(at)gmail(dot)com> writes:
> > FragmentDelimiter is an argument for ts_headline function to separates
> > different headline fragments. The default delimiter is " ... ".
> > Currently if someone specifies the delimiter as an option to the
> > function, no extra space is added around the delimiter. However, it does
> > not look good without space around the delimter.
>
> Maybe not to you, for the particular delimiter you happen to be working
> with, but it doesn't follow that spaces are always appropriate.
>
> > Since the option parsing function removes any space around the given
> > value, it is not possible to add any desired space. The attached patch
> > adds space when a FragmentDelimiter is specified.
>
> I think this is a pretty bad idea. Better would be to document how to
> get spaces into the delimiter, ie, use double quotes:
>
> ... FragmentDelimiter = " ... " ...
>
> Hmm, actually, it looks to me that the documentation already shows this,
> in the example of the default values.
>
> regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2009-03-02 06:08:57 Re: Immediate shutdown and system(3)
Previous Message Fujii Masao 2009-03-02 02:11:45 Re: Synchronous replication & Hot standby patches