Re: RFC: Additional Directory for Extensions

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Matheus Alcantara <matheusssilv97(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Gabriele Bartolini <gabriele(dot)bartolini(at)enterprisedb(dot)com>, Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>, "David E(dot) Wheeler" <david(at)justatheory(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Subject: Re: RFC: Additional Directory for Extensions
Date: 2025-02-25 12:45:10
Message-ID: 12312928-5516-49b8-81c1-a7b56fd01bc8@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2025-02-24 Mo 8:33 AM, Matheus Alcantara wrote:
> Hi,
>
> On Thu, Dec 5, 2024 at 8:07 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>> This patch is now complete enough for testing, I think. As I mentioned
>> earlier, I haven't updated pg_available_extensions() etc. to support the
>> path, but that shouldn't prevent some testing.
> To help with this patch I'm attaching a new version with the remaining TODOs
> fixed and also with a new TAP test.
>
> Thoughts?
>

I think your additions generally look good. We should be able to
simplify this:

+    system_dir = psprintf("%s/extension", sharepath);
+    ecp = system_dir;
+
+    if (strlen(Extension_control_path) == 0)
+    {
+        paths = lappend(paths, ecp);
+    }

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Verite 2025-02-25 13:10:31 Re: pgbench client-side performance issue on large scripts
Previous Message Andres Freund 2025-02-25 12:39:28 Re: Small memory fixes for pg_createsubcriber