| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [COMMITTERS] pgsql: Rework subtransaction commit protocol for hot standby. |
| Date: | 2008-10-28 00:35:52 |
| Message-ID: | 1225154152.3971.99.camel@ebony.2ndQuadrant |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, 2008-10-23 at 19:37 +0100, Simon Riggs wrote:
> I suggest a third version with these changes:
>
> * Write the SUBCOMMITTED to COMMIT transition as a no-op during redo
> rather than as an Assert. This prevents a transition from COMMIT to
> SUBCOMMIT to ABORT. By making it a no-op the attempt to set COMMIT to
> SUBCOMMIT never causes a failure, but it doesn't take place either.
>
> * Disallow SUBCOMMITTED to IN_PROGRESS transition via an Assert.
Even better idea: just use the InRecovery flag. Patch enclosed.
Comments please.
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
| Attachment | Content-Type | Size |
|---|---|---|
| clog_bug.v3.patch | text/x-patch | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | User Itagaki | 2008-10-28 05:51:43 | orafce - orafce: Now works on 8.2; remove concat() overloads on 8.2. |
| Previous Message | Alvaro Herrera | 2008-10-27 22:15:05 | pgsql: Downgrade can't-happen error reports to elog(). |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-10-28 00:52:02 | Re: CREATE TABLE AS WITH NO DATA |
| Previous Message | Kris Jurka | 2008-10-27 23:56:26 | Re: Any reason to have heap_(de)formtuple? |