Re: Add ps display while waiting for wal in read_local_xlog_page_guts

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: sirisha chamarthi <sirichamarthi22(at)gmail(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add ps display while waiting for wal in read_local_xlog_page_guts
Date: 2023-04-13 02:29:11
Message-ID: 1217448.1681352951@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

sirisha chamarthi <sirichamarthi22(at)gmail(dot)com> writes:
> pg_create_logical_replication_slot can take longer than usual on a standby
> when there is no activity on the primary. We don't have enough information
> in the pg_stat_activity or process title to debug why this is taking so
> long. Attached a small patch to update the process title while waiting for
> the wal in read_local_xlog_page_guts. Any thoughts on introducing a new
> wait event too?

set_ps_display is a fairly expensive operation on a lot of platforms,
so I'm concerned about the overhead this proposal would add. However,
getting rid of that pg_usleep in favor of a proper wait event seems
like a good idea.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2023-04-13 02:32:07 Re: Non-superuser subscription owners
Previous Message Tom Lane 2023-04-13 02:25:42 Re: Clean up hba.c of code freeing regexps