| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Bill Moran <wmoran(at)collaborativefusion(dot)com>, pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] Patch to log usage of temporary files |
| Date: | 2007-01-09 22:24:38 |
| Message-ID: | 11783.1168381478@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> Surely the measurement unit should be kbytes or disk blocks. And why
>> aren't you using that GUC UNITS infrastructure Peter put in?
> Agreed. I have applied the following patch to make it kilobytes, and
> documented it. I didn't put '-1kB' in the postgresql.conf file because
> the -1 value is special. (ideas?)
Hmm, that could be a little bit ugly. Suggestion: redefine the value
such that files *greater than* the given size are logged, and then zero
can be the "off" position, and we need not worry about whether -1 is
-1 byte or -1 kbyte.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-01-09 22:29:28 | Re: Last infomask bit |
| Previous Message | Bruce Momjian | 2007-01-09 22:20:00 | Re: [HACKERS] SGML index build fix |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-01-09 22:29:28 | Re: Last infomask bit |
| Previous Message | Bruce Momjian | 2007-01-09 22:23:02 | Re: Update UTF-8 RFC reference |