Re: ALTER TABLE INHERIT vs collations

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: ALTER TABLE INHERIT vs collations
Date: 2011-04-17 20:09:19
Message-ID: 11689.1303070959@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On Sat, 2011-04-16 at 18:23 -0400, Tom Lane wrote:
>> Right at the moment, ALTER INHERIT doesn't verify that collations
>> match in a proposed inheritance child.

> It should be prevented, I think.

BTW, on looking through the source to find the cause, I see that the
reason it's not prevented is that MergeAttributesIntoExisting() failed
to check for collation match. But the other three places in tablecmds.c
that check for child column type matches do check collation too. So it
seems clear that this was just an oversight in one case.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Radosław Smogura 2011-04-17 20:09:24 Re: MMAP Buffers
Previous Message Robert Haas 2011-04-17 20:01:55 Re: MMAP Buffers