Re: Anti-critical-section assertion failure in mcxt.c reached by walsender

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Noah Misch <noah(at)leadboat(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: Anti-critical-section assertion failure in mcxt.c reached by walsender
Date: 2021-05-07 20:30:00
Message-ID: 113762.1620419400@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> Isn't this a good reason to have at least some tests run with fsync=on?

Why?

I can certainly see an argument for running some buildfarm animals
with fsync on (for all tests). I don't see a reason for forcing
them all to run some tests that way; and if I were going to do that,
I doubt that 008_fsm_truncation.pl would be the one I would pick.
I think it's nothing but sloppiness that that one is out of step with
all the rest.

IMO, if a buildfarm owner sets fsync = off, they mean off.
They don't mean "maybe".

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2021-05-07 20:43:09 Re: batch fdw insert bug (Postgres 14)
Previous Message Tom Lane 2021-05-07 20:25:38 Re: Draft back-branch release notes are up