| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Possible bug: SQL function parameter in window frame definition |
| Date: | 2019-10-02 16:56:29 |
| Message-ID: | 10438.1570035389@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> writes:
> OK. So here's the final patch.
> (For the benefit of anyone in -hackers not following the original thread
> in -general, the problem here is that expressions in window framing
> clauses were not being walked or mutated by query_tree_walker /
> query_tree_mutator. This has been wrong ever since 9.0, but somehow
> nobody seems to have noticed until now.)
Two nitpicky suggestions:
* Please run it through pgindent. Otherwise v13+ are going to be randomly
different from older branches in this area, once we next pgindent HEAD.
* I think you missed s/walk/mutate/ in some of the comments you copied
into query_tree_mutator.
Looks good otherwise.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2019-10-02 17:15:37 | Re: Possible bug: SQL function parameter in window frame definition |
| Previous Message | Andrew Gierth | 2019-10-02 16:50:13 | Re: Possible bug: SQL function parameter in window frame definition |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2019-10-02 17:15:37 | Re: Possible bug: SQL function parameter in window frame definition |
| Previous Message | Pavel Stehule | 2019-10-02 16:50:46 | Re: dropdb --force |