Re: Vintage unused variables in pg_dump.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Vintage unused variables in pg_dump.c
Date: 2020-05-18 17:22:38
Message-ID: 1036.1589822558@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> Unless I'm missing something, the g_comment_start and g_comment_end variables
> in pg_dump.c seems to have been unused since 30ab5bd43d8f2082659191 (in the 7.2
> cycle) and can probably be safely removed by now.

Indeed. (Well, I didn't verify your statement about when they were
last used, but they're clearly dead now.) Pushed.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2020-05-18 17:54:03 Re: Why is pq_begintypsend so slow?
Previous Message Alvaro Herrera 2020-05-18 17:03:23 Re: Missing grammar production for WITH TIES