Re: WIP patch: improve documentation for user defined final functions of aggregates

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Mark Dilger <markdilger(at)yahoo(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WIP patch: improve documentation for user defined final functions of aggregates
Date: 2014-01-08 18:32:27
Message-ID: 10344.1389205947@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Mark Dilger <markdilger(at)yahoo(dot)com> writes:
> The fact that a final function may be called
> multiple times does not appear to be mentioned
> in the docs,

It's in xaggr.sgml, near the discussion of AggCheckCallContext
(the end of section 35.10, in current HEAD's section numbering).

In general, people writing C functions should not expect that they
can scribble on pass-by-ref arguments, so I don't see a need to
belabor the point in multiple places.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2014-01-08 18:45:37 Time to do our Triage for 9.4
Previous Message Mark Dilger 2014-01-08 18:10:24 WIP patch: improve documentation for user defined final functions of aggregates