| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: Test to dump and restore objects left behind by regression |
| Date: | 2024-10-31 14:26:01 |
| Message-ID: | 1018893.1730384761@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On my laptop, testing the plain format adds roughly 12s, in a test
> that now takes 1m20s to run vs 1m32s. Enabling regress_dump_formats
> and adding three more formats counts for 45s of runtime. For a test
> that usually shows up as the last one to finish for a heavily
> parallelized run. So even the default of "plain" is going to be
> noticeable, I am afraid.
Yeah, that's what I've been afraid of from the start. There's
no way that this will buy us enough new coverage to justify
that sort of addition to every check-world run.
I'd be okay with adding it in a form where the default behavior
is to do no additional checking. Whether that's worth maintaining
is hard to say though.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2024-10-31 14:26:57 | Re: Proper object locking for GRANT/REVOKE |
| Previous Message | Melanie Plageman | 2024-10-31 14:22:20 | Re: Count and log pages set all-frozen by vacuum |