Re: psql \e broken again

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: psql \e broken again
Date: 2004-11-14 18:55:27
Message-ID: 10051.1100458527@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> A remember specifically that I somewhat recently fixed psql to accept
> editors with arguments, say EDITOR="pico -t". This was apparently
> broken again during some Windows-related reshuffling. It now takes the
> editor as one quoted string rather than possibly several shell tokens.
> Could this please be fixed?

I think the rationale was to allow paths containing spaces, which is
a pretty serious problem on Windows. Seems like we have two basic
options:

1. Quote only on Windows.

2. Expect user to put quotes in the EDITOR value if it contains a
space-containing path.

I don't much care for either of these :-(.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2004-11-14 19:11:30 Re: psql \e broken again
Previous Message Peter Eisentraut 2004-11-14 18:29:58 psql \e broken again

Browse pgsql-patches by date

  From Date Subject
Next Message Peter Eisentraut 2004-11-14 19:11:30 Re: psql \e broken again
Previous Message Peter Eisentraut 2004-11-14 18:29:58 psql \e broken again