Re: Remove unnecessary 'always:' from CompilerWarnings task

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove unnecessary 'always:' from CompilerWarnings task
Date: 2023-11-08 07:31:00
Message-ID: 0fd7f15c-ac65-4e0b-93b7-fd0eb5df1dcf@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 05.09.23 12:25, Nazir Bilal Yavuz wrote:
> There are multiple 'always:' keywords under the CompilerWarnings task.
> Instead of that, we can use one 'always:' and move the instructions
> under this. So, I removed unnecessary ones and rearranged indents
> according to that change.

I'm not sure this change is beneficial. The way the code is currently
arranged, it's a bit easier to move or change individual blocks, and
it's also easier to read the file, because the "always:" is next to each
"script" and doesn't scroll off the screen.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2023-11-08 07:31:28 Re: ensure, not insure
Previous Message Peter Eisentraut 2023-11-08 07:20:30 Re: GenBKI emits useless open;close for catalogs without rows