Re: BUG #16920: Can't compile PostGIS with MingW64 against PostgreSQL 14 head

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Regina Obe <lr(at)pcorp(dot)us>, 'Tom Lane' <tgl(at)sss(dot)pgh(dot)pa(dot)us>, 'Juan José Santamaría Flecha' <juanjo(dot)santamaria(at)gmail(dot)com>
Cc: 'PostgreSQL mailing lists' <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #16920: Can't compile PostGIS with MingW64 against PostgreSQL 14 head
Date: 2021-03-14 08:10:15
Message-ID: 0bf7c953-ea90-7c74-0f97-4e0e83d09dc9@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 14/03/2021 02:30, Regina Obe wrote:
>> I wrote:
>>> Hmm, interesting. The gcc manual is quite negative about these though:
>>> https://gcc.gnu.org/onlinedocs/gcc/Nonlocal-Gotos.html
>>> Also it's not clear that these are compatible with <setjmp.h>'s
>>> version of jmp_buf.
>>
>> After further study, I think we could fix the jmp_buf inconsistency as
>> attached.
>>
>> I did some googling and found that we'd be in pretty good company if we go
>> this way: a lot of other projects have concluded that MinGW-64's
>> setjmp() is hopelessly buggy and adopted this same workaround. It still
>> makes me a bit nervous though, as this is a serious ABI break for anything
>> using setjmp/longjmp. We could not back-patch such a change, and once we
>> ship a release using this we're stuck with it in that release branch.
>>
>> Regina, could you confirm whether this fixes things for you?
>>
>> regards, tom lane
>
> Confirmed both PostgreSQL and PostGIS pass all tests with this patch.

Is this the same issue that was discussed here?

https://www.postgresql.org/message-id/flat/f1caef93-9640-022e-9211-bbe8755a56b0%402ndQuadrant.com

- Heikki

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2021-03-14 08:56:37 Re: BUG #16920: Can't compile PostGIS with MingW64 against PostgreSQL 14 head
Previous Message PG Bug reporting form 2021-03-14 00:43:35 BUG #16926: initdb fails on Windows when binary path contains certain non-ASCII characters