From: | "Regina Obe" <lr(at)pcorp(dot)us> |
---|---|
To: | "'Tom Lane'" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, 'Juan José Santamaría Flecha' <juanjo(dot)santamaria(at)gmail(dot)com> |
Cc: | "'PostgreSQL mailing lists'" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
Subject: | RE: BUG #16920: Can't compile PostGIS with MingW64 against PostgreSQL 14 head |
Date: | 2021-03-14 00:30:03 |
Message-ID: | 000d01d71869$2dabde70$89039b50$@pcorp.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
> I wrote:
> > Hmm, interesting. The gcc manual is quite negative about these though:
> > https://gcc.gnu.org/onlinedocs/gcc/Nonlocal-Gotos.html
> > Also it's not clear that these are compatible with <setjmp.h>'s
> > version of jmp_buf.
>
> After further study, I think we could fix the jmp_buf inconsistency as
> attached.
>
> I did some googling and found that we'd be in pretty good company if we go
> this way: a lot of other projects have concluded that MinGW-64's
> setjmp() is hopelessly buggy and adopted this same workaround. It still
> makes me a bit nervous though, as this is a serious ABI break for anything
> using setjmp/longjmp. We could not back-patch such a change, and once we
> ship a release using this we're stuck with it in that release branch.
>
> Regina, could you confirm whether this fixes things for you?
>
> regards, tom lane
Confirmed both PostgreSQL and PostGIS pass all tests with this patch.
From | Date | Subject | |
---|---|---|---|
Next Message | PG Bug reporting form | 2021-03-14 00:43:35 | BUG #16926: initdb fails on Windows when binary path contains certain non-ASCII characters |
Previous Message | Tom Lane | 2021-03-13 23:38:59 | Re: BUG #16920: Can't compile PostGIS with MingW64 against PostgreSQL 14 head |