| From: | Liudmila Mantrova <l(dot)mantrova(at)postgrespro(dot)ru> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: s/rewinded/rewound/? |
| Date: | 2019-08-07 09:48:29 |
| Message-ID: | 0b950a4b-ef20-96d6-c34f-8f2424503d27@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 8/7/19 12:00 PM, Michael Paquier wrote:
> On Wed, Aug 07, 2019 at 10:53:45AM +0200, Magnus Hagander wrote:
>> To me this sounds like a classic non-English-native-speaker-mistake. But
>> it seems at least the one in the docs come from Bruce, who definitely is...
>> So perhaps it's intentional to refer to "what pg_rewind does", and not
>> necessarily to the regular word for it?
> I am not sure :)
> "rewound" sounds much more natural.
> --
> Michael
+1 for rewound from a non-English-native-speaker. The use of "rewound"
in the same file also supports Michael's view.
If we decide to fix this, we should probably revise and back-patch the
whole paragraph where it appears as it seems to mix up scanning target
cluster
WALs and applying source cluster WALs. A small patch is attached for
your consideration (originally proposed on pgsql-docs [1]).
[1]
https://www.postgresql.org/message-id/ad6ac5bb-6689-ddb0-dc60-c5fc197d728e%40postgrespro.ru
--
Liudmila Mantrova
Technical writer at Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| pg-rewind-doc-fix.patch | text/x-patch | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ibrar Ahmed | 2019-08-07 09:52:12 | Re: block-level incremental backup |
| Previous Message | Jeevan Chalke | 2019-08-07 09:46:43 | Re: block-level incremental backup |