Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line

From: Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, vladimirlesk(at)yandex-team(dot)ru, dsarafan(at)yandex-team(dot)ru
Subject: Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line
Date: 2019-02-11 09:56:45
Message-ID: 0a144e58-4b4c-762b-bbc4-831a8eb32dd6@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi!

On 09.02.2019 14:31, Andrey Borodin wrote:
> Here's a typo in postgreslq.conf
> + fprintf(stderr, _("%s: option -r/--use-postgresql-conf is specified, but postgreslq.conf is absent in the target directory\n"),

Fixed, thanks. I do not attach new version of the patch for just one
typo, maybe there will be some more remarks from others.

> Besides this, I think you can switch patch to "Ready for committer".
>
> check-world is passing on macbook, docs are here, feature is implemented and tested.

OK, cfbot [1] does not complain about anything on Linux and Windows as
well, so I am setting it to "Ready for committer" for the next commitfest.

[1] http://cfbot.cputube.org/alexey-kondratov.html

Regards

--
Alexey Kondratov

Postgres Professional https://www.postgrespro.com
Russian Postgres Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Meskes 2019-02-11 09:58:04 Re: [PROPOSAL]a new data type 'bytea' for ECPG
Previous Message Peter Eisentraut 2019-02-11 08:44:24 Re: Reporting script runtimes in pg_regress