| From: | "Okano, Naoki" <okano(dot)naoki(at)jp(dot)fujitsu(dot)com> |
|---|---|
| To: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Cc: | Euler Taveira <euler(at)timbira(dot)com(dot)br>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_recvlogical --endpos |
| Date: | 2016-11-30 05:26:48 |
| Message-ID: | 0B4917A40C80E34BBEC4BE1A7A9AB7E277B59C@g01jpexmbkw05 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wednesday, November 30, 2016 10:34 AM Craig Ringer wrote:
>On 30 November 2016 at 09:18, Okano, Naoki <okano(dot)naoki(at)jp(dot)fujitsu(dot)com> wrote:
>>
>> On November 29, 2016 at 5:03 PM Craig Ringer wrote:
>>> Would it be better rephrased as "--endpos can only be used with --start" ?
>> OK. I think this phrase is better than the previous phrase.
>>
>>>> The patch should allow --endpos to work with --create-slot.
>>>
>>> How? It doesn't make sense with --create-slot .
>> This patch is updated to incorporate Alvaro's changes shown below, isn't it?
>> https://www.postgresql.org/message-id/20160503180658.GA59498%40alvherre.pgsql
>> I thought that the consent in community was taken with this specification...
>>> I could not find any mention that it did not make sense with --create-slot.
> What would --endpos with --create-slot do?
Sorry, I was misunderstanding. you are right.
I have noticed that --endpos doesn't make sense unless it is with --start.
I checked --endpos works with --create-slot and --start.
So, there is no problem with this patch.
Regards,
Okano Naoki
Fujitsu
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2016-11-30 05:30:37 | Re: patch: function xmltable |
| Previous Message | Magnus Hagander | 2016-11-30 03:30:13 | Re: Remove the comment on the countereffectiveness of large shared_buffers on Windows |