From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Antonin Houska <ah(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PoC] Federated Authn/z with OAUTHBEARER |
Date: | 2024-12-15 22:18:39 |
Message-ID: | 08D9D93D-EC27-469C-8276-94BDFBFCB55A@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 5 Dec 2024, at 19:29, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> wrote:
> Seems good. I think this part of the API is going to need an
> ABI-compatibility pass, too. For example, do we want a module to
> allocate the result struct itself (which locks in the struct length)?
> And should we have a MAGIC_NUMBER of some sort in the static callback
> list, maybe?
I think we should, I just now experimented with setting the server major
version (backed by PG_VERSION_NUM) in the callback struct and added a simple
test. I'm not sure if there is a whole lot more we need, maybe an opaque
integer for the module to identify its version?
> --with-libcurl/-Dlibcurl, and the Autoconf side uses PKG_CHECK_MODULES
> exclusively.
Why only use PKG_CHECK_MODULES for this rather than treating it more like other
dependencies where we fall back on other methods if not found? While I'm
clearly not the target audience, I build libcurl all the time and being able to
point to a directory would be nice. There's also the curl-config utility which
should be in all packaged versions.
--
Daniel Gustafsson
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2024-12-16 02:25:16 | Re: confusing / inefficient "need_transcoding" handling in copy |
Previous Message | Tomas Vondra | 2024-12-15 21:46:58 | Maybe we should reduce SKIP_PAGES_THRESHOLD a bit? |