Re: [Proposal] Add foreign-server health checks infrastructure

On 2024/08/08 11:38, Hayato Kuroda (Fujitsu) wrote:
> Dear Fujii-san,
>
> Thanks for reviewing! PSA new version.

Thanks for updating the patch! LGTM.

I made a couple of small adjustments and attached the updated version.
If that's ok, I'll go ahead and commit it.

+ Name of the local user mapped to the foreign server of this
+ connection, or "public" if a public mapping is used. If the user

I enclosed "public" with <literal> tag, i.e., <literal>public</literal>.

> I did not done that be cause either of server_name or user_name is NULL and
> it might be strange. But yes, the example should have more information.
> Based on that, I added a tuple so that the example has below. Thought?
>
> loopback1 - user is "postgres", valid
> loopback2 - user is "public", valid
> loopback3 - user is NULL, invalid

LGTM.
Also I added the following to the example for clarity:

postgres=# SELECT * FROM postgres_fdw_get_connections(true);

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION