Re: [PATCHES] c.h is the problem of msvc.

From: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] c.h is the problem of msvc.
Date: 2006-07-14 22:37:01
Message-ID: 022401c6a796$06689cd0$0801a8c0@IBMC4B5932F74B
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Ooops,
I am uncertain at the reason for not knowing __BORLANDC__...
It will be sure if __BORLANDC__ has the definition.
Thanks.

Regards,
Hiroshi Saito

From: "Tom Lane"

> "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> writes:
>> --- src/include/c.h.orig Sat Jul 15 01:38:59 2006
>> +++ src/include/c.h Sat Jul 15 01:40:04 2006
>> @@ -60,7 +60,9 @@
>> #if defined(_MSC_VER) || defined(__BORLANDC__)
>> #define WIN32_ONLY_COMPILER
>> #define errcode __vc_errcode
>> +#if (_MSC_VER > 1400)
>> #include <crtdefs.h>
>> +#endif
>> #undef errcode
>> #endif
>>
>
> This patch certainly looks like it will break the __BORLANDC__ build ...
>
> regards, tom lane

Attachment Content-Type Size
msvc_c_patch application/octet-stream 324 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-07-14 23:06:20 Re: src/tools/pginclude considered harmful (was Re: [PATCHES]
Previous Message Teodor Sigaev 2006-07-14 22:35:12 Re: contrib promotion?

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-07-14 23:06:20 Re: src/tools/pginclude considered harmful (was Re: [PATCHES]
Previous Message Bruce Momjian 2006-07-14 22:03:31 Re: src/tools/pginclude considered harmful (was Re: