| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Minor cleanups in the SSL tests |
| Date: | 2024-05-16 07:24:12 |
| Message-ID: | 01F4684C-8C98-4BBE-AB83-AC8D7C746AF8@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
When writing a new SSL test for another patch it struck me that the SSL tests
are doing configuration management without using the test framework API's. The
attached patches cleans this up, no testcases are altered as part of this.
0001 makes the test for PG_TEST_EXTRA a top-level if statement not attached to
any other conditional. There is no change in functionality, it's mainly for
readability (PG_TEST_EXTRA is it's own concept, not tied to library presence).
0002 ports over editing configfiles to using append_conf() instead of opening
and writing to them directly.
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| 0002-Use-library-functions-to-edit-config-in-SSL-tests.patch | application/octet-stream | 5.7 KB |
| 0001-Test-for-PG_TEST_EXTRA-separately.patch | application/octet-stream | 2.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrei Lepikhov | 2024-05-16 07:47:01 | Re: POC: GROUP BY optimization |
| Previous Message | Peter Smith | 2024-05-16 07:04:38 | Re: Docs: Always use true|false instead of sometimes on|off for the subscription options |