Re: Valgrind suppressions in back branches not working

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Valgrind suppressions in back branches not working
Date: 2025-03-06 13:50:14
Message-ID: zmcn5hklsi5yppztegjcjvdvxku4ylzviywwc4c6max6b6qor4@kuuiexvynong
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2025-03-05 16:28:21 -0500, Andres Freund wrote:
> Some time recently valgrind suppressions in the older backbranches stopped
> fully working. E.g.
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2025-03-04%2022%3A31%3A25
> failed on 14, with:
>
> [...]
>
> An embarassing amount of staring later I realized this must be due to the
> cancellation related functions in the stack trace.
>
>
> I think all we need to do is to add a ... line to the two relevant
> suppressions, similar to what we do for other suppressions. See attached.
>
>
> I don't think we need it for other suppressions, they either already use
> ... or aren't below a syscall.

Pushed to 13 and 14, may skink be well.

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2025-03-06 13:51:02 Re: jsonb_strip_nulls with arrays?
Previous Message Corey Huinker 2025-03-06 13:49:33 Re: Statistics Import and Export