Re: Decision by Monday: PQescapeString() vs. encoding violation

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Decision by Monday: PQescapeString() vs. encoding violation
Date: 2025-02-15 20:59:43
Message-ID: yzs7j6ivvwhbxvg2bgwzv3ywy5yh5u5w2c6udygkcvk3jcqk5h@dikyjy5dyfev
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2025-02-15 15:52:01 -0500, Tom Lane wrote:
> The v5 patch seems Good Enough(TM) to me.

Agreed.

> We can refine it later perhaps; I don't think something like the above would
> affect anything that external code should care about.

I don't really think it's worth spending cycles on this anytime soon. It makes
sense to put the effort in to replace invalid "characters" in a minimal way
when intending to actually use the "stripped" output permanently. But all
we're trying to do here is to a) ensure that the backend will error out b)
reduce the chances that other tooling (psql, xml parsers, ..) get confused due
to invalidly encoded data.

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2025-02-15 20:59:56 Re: Decision by Monday: PQescapeString() vs. encoding violation
Previous Message Tom Lane 2025-02-15 20:53:20 Re: Decision by Monday: PQescapeString() vs. encoding violation