From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | should I post the patch as committed? |
Date: | 2010-04-20 15:39:11 |
Message-ID: | w2v603c8f071004200839g9b664b5au9581ec6dba6b240c@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Apr 18, 2010 at 8:55 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Thanks for the review. Committed with revisions along the lines you suggest.
Bruce suggested to me off-list that when I commit a patch with
revisions, I ought to attach the committed patch to the email in which
I say that I have committed it. I know that Bruce habitually does
this, but I've never found it very helpful, since I prefer to look at
the patch either using the pgsql-committers emails or the git
respository. On the other hand, Bruce tells me he's received positive
feedback on the way he does it.
After some off-list discussion, we thought it would be good to ask the
list for feedback on this topic - is it helpful to attach the
patch-as-committed to the -hackers email, or is it just duplicative of
what's already available elsewhere?
...Robert
From | Date | Subject | |
---|---|---|---|
Next Message | Korry Douglas | 2010-04-20 16:00:23 | Why does TRIM() expect an expr_list? |
Previous Message | Tom Lane | 2010-04-20 15:24:43 | Re: CTAS not honoring NOT NULL, DEFAULT modifiers |