Re: [PATCHES] HP-UX PA-RISC/Itanium 64-bit Patch and HP-UX 11.23 Patch

From: Shinji Teragaito <shinji(at)kobe(dot)hp(dot)com>
To: pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCHES] HP-UX PA-RISC/Itanium 64-bit Patch and HP-UX 11.23 Patch
Date: 2004-08-31 11:00:14
Message-ID: vvdy8jvd135.wl%Shinji.Teragaito@hp.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

>> On Tue, 24 Aug 2004 00:39:55 -0400, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> said:

> Shinji Teragaito <shinji(at)kobe(dot)hp(dot)com> writes:
>> I made a patch to let PostgreSQL work in the LP64 data model on
>> HP-UX PA-RISC and HP-UX Itanium platform.

> The s_lock change looks good ... but ...

> This patch seems likely to break many other platforms. You do not
> seriously expect us to apply that change to float8.out, do you?

My patch is not related to the failure of the float8 test. Because
you can see this failure when you compile the original cvs source code
using GCC 3.4.1 on HP-UX 11.23 (Itanium) and run the regression test.
Besides the failure of the float8 test, the create_function_1 and
triggers tests fail. Please refer to the attached regression.diff. The
result of float8.out diffs in this file are the same with the result I
can see under the environment my patch is applied.

The reason refint.sl has unresolved external symbol (__divdi3) is
it's linked by /usr/ccs/bin/ld without libgcc.a. This is implemented
in src/Makefile.port. Makefile.port in my patch use GCC to link
refint.so. It results to link refint.so with libgcc.a implicitly and
automatically. Anyway my patch will eliminate the failures of the
create_function_1 and triggers test when GCC on HP-UX 11.23 will be
used regardless of ILP32 or LP64.

> I'd also like to know the rationale for the Makefile.shlib changes
> (which did not seem to be needed the last time I tested on HPUX 11)

Note I don't see this unresolved symbol problem when I use GCC 3.4.1
on HP-UX 11.11 (PA-RISC) even if my patch is not applied. I have not
look into this deeply (I'm just wondering millicode routine on PA-RISC
is related to this).

Cheers,

Shinji Teragaito
Hewlett-Packard Japan, Ltd.

Attachment Content-Type Size
regression.diffs application/octet-stream 6.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-08-31 11:31:36 Re: [pgsql-hackers-win32] Testing needed for recent tablespace
Previous Message markir 2004-08-31 07:22:01 Re: Testing needed for recent tablespace

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-08-31 14:31:03 Re: [PATCHES] ALTER SCHEMA ... SET TABLESPACE
Previous Message Andreas Pflug 2004-08-31 08:55:26 Re: log_filename_prefix --> log_filename + strftime()