Re: pgadmin4 setup.py, first time run

From: Prasad <prasad(dot)s(at)mail(dot)com>
To: "Khushboo Vashi" <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: "Dave Page" <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgadmin4 setup.py, first time run
Date: 2015-09-07 11:57:35
Message-ID: trinity-504c3380-a04b-42e0-8cf4-50b886acebb5-1441627054940@3capp-mailcom-lxa10
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

<html><head></head><body><div style="font-family: Verdana;font-size: 12.0px;"><div>I&#39;d this issue on Ubuntu x64. And using Python editor IDLE to run setup.py</div>

<div>&nbsp;</div>

<div>regards,</div>

<div>Prasad Somwanshi<br/>
<br/>
&nbsp;<br/>
&nbsp;<br/>
<br/>
Sent:&nbsp;Monday, September 07, 2015 at 12:36 PM<br/>
From:&nbsp;&quot;Khushboo Vashi&quot; &lt;khushboo(dot)vashi(at)enterprisedb(dot)com&gt;<br/>
To:&nbsp;&quot;Dave Page&quot; &lt;dpage(at)pgadmin(dot)org&gt;<br/>
Cc:&nbsp;Prasad &lt;prasad(dot)s(at)mail(dot)com&gt;, pgadmin-hackers &lt;pgadmin-hackers(at)postgresql(dot)org&gt;<br/>
Subject:&nbsp;Re: [pgadmin-hackers] pgadmin4 setup.py, first time run<br/>
<br/>
Hi Dave,<br/>
<br/>
I have tried to reproduce the issue but couldn&#39;t reproduce it on UBUNTU as well as on MAC.<br/>
<br/>
I have checked the online examples of SQLAlchemyUserDatastore, and I think<br/>
it is logical that before assigning the new role to the newly created user,&nbsp; user should be committed first.<br/>
&nbsp;Thanks,Khushboo<br/>
<br/>
&nbsp;<br/>
On Mon, Sep 7, 2015 at 1:49 PM, Khushboo Vashi &lt;khushboo(dot)vashi(at)enterprisedb(dot)com&gt; wrote:<br/>
<br/>
Yes. I am looking into this.<br/>
&nbsp;Thanks,Khushboo<br/>
<br/>
&nbsp;<br/>
On Mon, Sep 7, 2015 at 1:31 PM, Dave Page &lt;dpage(at)pgadmin(dot)org[dpage@pgadmin.org]&gt; wrote:Khushboo, can you look at this please?<br/>
<br/>
Thanks.<br/>
<br/>
On Sun, Sep 6, 2015 at 12:42 AM, Prasad &lt;prasad(dot)s(at)mail(dot)com[prasad(dot)s@mail.com]&gt; wrote:<br/>
&gt; Hi,<br/>
&gt;<br/>
&gt; When you try to run pgadmin4 for first time(without presence of pgadmin4.db), it ask you to run setup.py. When you run it, it throws python error as follows,<br/>
&gt; Traceback (most recent call last):<br/>
&gt;&nbsp; &nbsp;File &quot;/home/test/Development/pgadmin4/web/setup.py&quot;, line 145, in &lt;module&gt;<br/>
&gt;&nbsp; &nbsp; &nbsp;do_setup(app)<br/>
&gt;&nbsp; &nbsp;File &quot;/home/test/Development/pgadmin4/web/setup.py&quot;, line 57, in do_setup<br/>
&gt;&nbsp; &nbsp; &nbsp;user_datastore.add_role_to_user(email, &#39;Administrators&#39;)<br/>
&gt;&nbsp; &nbsp;File &quot;/usr/local/lib/python2.7/dist-packages/Flask_Security-1.7.4-py2.7.egg/flask_security/datastore.py&quot;, line 106, in add_role_to_user<br/>
&gt;&nbsp; &nbsp; &nbsp;if role not in user.roles:<br/>
&gt; AttributeError: &#39;NoneType&#39; object has no attribute &#39;roles&#39;<br/>
&gt;<br/>
&gt; It&#39;s because,user_datastore.create_role,user_datastore.create_user and user_datastore.add_role_to_user all calls are for in one database transaction. It need to commit it after first two calls or creating role and user for add_role_to_user to work,<br/>
&gt;<br/>
&gt; Find attached patch for this.<br/>
&gt;<br/>
&gt; regards,<br/>
&gt; Prasad Somwanshi<br/>
&gt;<br/>
&gt;<br/>
&gt; --<br/>
&gt; Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org[pgadmin-hackers@postgresql.org])<br/>
&gt; To make changes to your subscription:<br/>
&gt; <a href="http://www.postgresql.org/mailpref/pgadmin-hackers" target="_blank">http://www.postgresql.org/mailpref/pgadmin-hackers</a>[<a href="http://www.postgresql.org/mailpref/pgadmin-hackers" target="_blank">http://www.postgresql.org/mailpref/pgadmin-hackers</a>]<br/>
&gt;<br/>
<br/>
<br/>
<br/>
--<br/>
Dave Page<br/>
Blog: <a href="http://pgsnake.blogspot.com" target="_blank">http://pgsnake.blogspot.com</a>[<a href="http://pgsnake.blogspot.com" target="_blank">http://pgsnake.blogspot.com</a>]<br/>
Twitter: @pgsnake<br/>
<br/>
EnterpriseDB UK: <a href="http://www.enterprisedb.com" target="_blank">http://www.enterprisedb.com</a>[<a href="http://www.enterprisedb.com" target="_blank">http://www.enterprisedb.com</a>]<br/>
The Enterprise PostgreSQL Company</div></div></body></html>

Attachment Content-Type Size
unknown_filename text/html 3.7 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2015-09-07 11:58:19 Re: pgadmin4 setup.py, first time run
Previous Message Khushboo Vashi 2015-09-07 11:36:33 Re: pgadmin4 setup.py, first time run