[pgadmin-org/pgadmin4] 62056c: Fixed sonaqube security smells and bugs

Branch: refs/heads/master
Home: https://github.com/pgadmin-org/pgadmin4
Commit: 62056cab14e52017dd3a4c9a81ccc5a36508da65
https://github.com/pgadmin-org/pgadmin4/commit/62056cab14e52017dd3a4c9a81ccc5a36508da65
Author: Pravesh Sharma <pravesh(dot)sharma(at)enterprisedb(dot)com>
Date: 2023-07-10 (Mon, 10 Jul 2023)

Changed paths:
M runtime/src/js/pgadmin.js
M web/pgadmin/__init__.py
M web/pgadmin/authenticate/mfa/authenticator.py
M web/pgadmin/browser/server_groups/servers/databases/casts/static/js/cast.ui.js
M web/pgadmin/browser/server_groups/servers/databases/publications/__init__.py
M web/pgadmin/browser/server_groups/servers/databases/schemas/domains/static/js/domain.ui.js
M web/pgadmin/browser/server_groups/servers/databases/schemas/synonyms/static/js/synonym.ui.js
M web/pgadmin/browser/server_groups/servers/static/js/server.js
M web/pgadmin/static/js/pgadmin.js
M web/regression/javascript/SecurityPages/ForgotPasswordPage.spec.js
M web/regression/javascript/SecurityPages/LoginPage.spec.js
M web/regression/javascript/SecurityPages/MfaRegisterPage.spec.js
M web/regression/javascript/SecurityPages/MfaValidatePage.spec.js
M web/regression/javascript/SecurityPages/PasswordResetPage.spec.js

Log Message:
-----------
Fixed sonaqube security smells and bugs

1. Delete unreachable code or refactor the code to make it reachable.
2. Unexpected var, use let or const instead.
3. Remove useless assignment to variable.
4. Define a constant instead of duplicating the literal
5. Remove commented out code