| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers(at)postgresql(dot)org, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Reorder shutdown sequence, to flush pgstats later |
| Date: | 2025-01-10 18:42:11 |
| Message-ID: | oydtw7rxxdkltfvs4cffs3v5b3lwyi25dr7dgrsqilqv6iiv7l@cqbpk5zlgmci |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2025-01-09 16:50:45 +0300, Nazir Bilal Yavuz wrote:
> On Wed, 8 Jan 2025 at 22:26, Andres Freund <andres(at)anarazel(dot)de> wrote:
> === 0005
>
> > I think this is much better than before. I don't love PM_WAIT_XLOG_ARCHIVAL,
> > but I can't think of anything better.
>
> I liked this, I think it is good enough.
>
> - PM_SHUTDOWN, /* waiting for checkpointer to do shutdown
> + PM_WAIT_XLOG_SHUTDOWN, /* waiting for checkpointer to do shutdown
> * ckpt */
>
> There are couple of variables and functions which include pm_shutdown
> in their names:
> pending_pm_shutdown_request
> handle_pm_shutdown_request_signal()
> process_pm_shutdown_request()
>
> Do you think these need to be updated as well?
I don't think so - I think those are actually not specifically referencing the
PM_SHUTDOWN symbol. They're referencing shutting down postmaster - which
neither starts nor ends with PM_SHUTDOWN.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mat Arye | 2025-01-10 18:43:00 | Memory leak in plpython3u (with testcase and patch) |
| Previous Message | Yura Sokolov | 2025-01-10 18:33:57 | Re: [RFC] Lock-free XLog Reservation from WAL |