| From: | "Sven Suursoho" <sven(at)spam(dot)pri(dot)ee> |
|---|---|
| To: | "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: plpython improvements |
| Date: | 2006-04-30 15:36:21 |
| Message-ID: | op.s8tuyvmcplgmb3@localhost |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Hi,
Thu, 27 Apr 2006 17:17:36 +0300, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>:
> Sorry, I have to revert this patch because it is causing crashes in the
> plpython regression tests. Would you please run those tests, fix the
> bug, and resubmit. Thanks.
Found and fixed two problems:
1) named parameters handling if there were no parameters at all
2) didn't increment counter for borrowed reference fetched from list
Also integrated tests to plpython test suite and updated existing tests to
use named parameters.
Unfortunately, there is still one problem when using unpatched python,
caused by too aggressive assert.
See
http://mail.python.org/pipermail/python-checkins/2005-August/046571.html.
I guess there should be warning somewhere as Hannu said but didn't know
where to put it.
--
Sven Suursoho
| Attachment | Content-Type | Size |
|---|---|---|
| plpython.patch | text/x-patch | 32.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-04-30 16:14:28 | Re: plpython improvements |
| Previous Message | Magnus Hagander | 2006-04-30 08:56:14 | Re: pgstat: delayed write of stats file |