Re: walreceiver is uninterruptible on win32

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: walreceiver is uninterruptible on win32
Date: 2010-04-08 08:01:03
Message-ID: o2m3f0b79eb1004080101j287fd613uad9cc81033af0df7@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 7, 2010 at 1:45 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> No, I don't mean that. I mean store it in one place, and copy/link it
> into where it's used. Look at for example how crypt.c and
> getaddrinfo.c are handled in libpq.

Thanks for the advice!

> Not sure how that will play with PGXS, though, but I'm not entirely
> sure we care if it can be built that way?

Probably Yes.

> If it does, there should be
> some way to get PGXS to execute that rule as well, I'm sure.

If we can copy/link the source file defining "new PQexec" when
we compile the dblink, DLL doesn't seem to be required. So I
stop creating new DLL for PGXS.

> Also note that per Tom's comments this is not a win32 only fix, so it
> shouldn't be called pgwin32_*().

Yep.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2010-04-08 08:02:14 Re: A maze of twisty mailing lists all the same
Previous Message Dave Page 2010-04-08 07:47:25 Re: A maze of twisty mailing lists all the same