Re: pgagent status always successful

Hi Dave,

{"keep on the list! :)))" Dave said}

Yeah, I'll build something for Eric tomorrow morning.

Cheers,
Raph

----Message d'origine----
>Sujet: RE: [pgadmin-support] pgagent status always successful
>Date: Tue, 11 Jul 2006 21:51:19 +0100
>De: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
>A: <erics(at)ameri-title(dot)com>
>Copie à: Raphaël Enrici <blacknoz(at)club-internet(dot)fr>
>
>
>
>> -----Original Message-----
>> From: Eric Shuman [mailto:erics(at)ameri-title(dot)com]
>> Sent: 05 July 2006 22:07
>> To: Dave Page
>> Subject: RE: [pgadmin-support] pgagent status always successful
>>
>> Hi Dave,
>>
>> The "On Error" flag is set to fail.
>>
>> The script will run, but I have been trying to make it fail
>> by entering bad
>> code or wrong filenames just to test if the job would fail
>> and to see what
>> my statistics would be like when it does.
>>
>> The result values I get now in pgAdmin seem to be 5 digit
>> numbers (32512 for
>> example was the result of a call to the script using a bad
>> filename) I use
>> to always get a value of "1" no matter what.
>>
>> Errors will show up in the debugging, but the steps and job will still
>> always show "success".
>
>Hi Eric,
>
>Sorry for the delay. I just got to look at this some more and found that the return value is actually stored in the top 8 bits of the int returned by pclose(). I've applied suitable patched to convert that back to a signed value and now get sensible results in my testing. As per convention, any negative value will be seen as a failure.
>
>Raphael; I've committed patches to trunk and 1.4 - any chance you can rustle up another build for Eric to test for us please?
>
>Thanks, Dave.
>